Is vayne ever a bad pick? (As a whole not just laning)
She is (one of) the only tank shredder (yes there's kog but that's about it). She has mobility (unlike kog and jinx) and can save herself if someone decides to jump her. Jinx and kog can't say the same. Trist has a jump but she doesn't feel as powerful. Other adcs might be used for utility like varus ult or mf ult but vayne is the only "reliable" adc with tank shredding and that's why I think she's never a bad pick. She might get outlaned (debatable) but she always can come back. Late game dps is great and there is nothing really bad about her if you can position on the outside. Hitting tanks frontline with her isn't bad as she can just lifesteal any poke while helping her team. other adcs can't tank shred/
