13 Comments

DuskDaUmbreon13 votes

Literally unplayable, Riot!

...Okay. While this honestly isn't going to have impact, it should probably be fixed.

CrazFight 6 votes

More fucking proof that riots balance team is shit. After seeing this, the game is just un playable.

RIP LEAGUE 2018

Master Noct2 votes

How to cheat the system 101

Ifneth2 votes

That right there is embarrassing. Come on. Declare your variables, guys.

GigglesO2 votes

They probably only use global variables too.

[sg-janna]

Ifneth4 votes

{quoted}

They probably only use global variables too.

[sg-janna]

shudders

Modl Ryden l2 votes

Item cooldowns are static or 'final'. Ingenious Hunter, Cosmic Insight, and Perfect Timing don't change their displayed cooldowns in game.

They do affect them however. But for the sake of clarity, Zhonya's for example will constantly display 120 sec cooldown. But with all 3 afformentioned runes the cooldown does become shortened significantly. Approximately down to 42 seconds.

AnataBakka1 votes

lol, big bug xD

DarkKatalyst1 votes

C'mon, give the intern a break!

rtbf761092711 votes

Both tooltips are probably reading the same variable but just showing them slightly different. I would guess the inconsistency is one conversion to a string for the UI is truncating and the other is rounding

Jesus is Savior1 votes

{quoted}

Both tooltips are probably reading the same variable but just showing them slightly different. I would guess the inconsistency is one conversion to a string for the UI is truncating and the other is rounding

Yes, hence the topic title. "Someone is using a float when they should be using an int!"

If it was declared in the code as an integer, then there would be nothing to round, and nothing to truncate.

rtbf761092711 votes

[{quoted}](name=I Follow Christ,realm=NA,application-id=LqLKtMpN,discussion-id=7jcf93nr,comment-id=00070000,timestamp=2018-01-30T04:20:44.007+0000)

Yes, hence the topic title. "Someone is using a float when they should be using an int!"

If it was declared in the code as an integer, then there would be nothing to round, and nothing to truncate.

There may be advantages to having it stored as a float. First off, it will usually result in a decimal when you take 0.4 or 0.7 and multiply it with an item gold value. If you ALWAYS truncate then you are losing information, which might be useless information but it might not. I can't think of a reason that the truncation error would matter, but it might somewhere some place.

Also, any further math may not compile depending on what language you use. Some languages do not allow ints to be used in methods which expect floats without explicit casting, so it might be easier to always have all gold values as floats and just display it on the UI as a rounded or truncated integer. So if they changed that 0.4 * item value to an int, they may need to go 100 other places in the code and add promote it to a float anyways

Catastrophic1 votes

What's next? Using SPACES instead of tabs?

More from Report a Bug

More by Jesus is Savior