Why does it take more than a day to fix sorc boot?

gamezzs·Jul 21, 2014·6 votes·2,503 views

This shouldn't have happened in the first place, but how long does it take to fix what is probably 1 line of code?

13 Comments

RiotricklessabandonJul 21, 20149 votes

it took me a few seconds to fix it, which happened after a few minutes of checking the file histories of a couple things. i think the scripting side of things (before testing or anything) had a fix candidate before i started seeing people talk about it on social media, and definitely before we disabled the item. the reason that the fix isn't already live is because of the process that happens after that (which was made more complicated in this case because we were preparing the 4.12 patch for deployment for regions that didn't have it yet). one of those steps is making sure that the candidate actually fixes the issue, so it's pretty important stuff that we don't want to skip.

i think the current plans would have the fix out to north america early this week, though i don't know exactly when as that's handled by other teams. the moral of the story is that it's really important to make sure things work right the first time, so no one has to suffer through a disruption in normal play because of bugs like this. :<

MrSc0ttyJul 21, 20141 votes

it took me a few seconds to fix it, which happened after a few minutes of checking the file histories of a couple things. i think the scripting side of things (before testing or anything) had a fix candidate before i started seeing people talk about it on social media, and definitely before we disabled the item. the reason that the fix isn't already live is because of the process that happens after that (which was made more complicated in this case because we were preparing the 4.12 patch for deployment for regions that didn't have it yet). one of those steps is making sure that the candidate actually fixes the issue, so it's pretty important stuff that we don't want to skip.

i think the current plans would have the fix out to north america early this week, though i don't know exactly when as that's handled by other teams. the moral of the story is that it's really important to make sure things work right the first time, so no one has to suffer through a disruption in normal play because of bugs like this. :<

Lemme guess.

Parenthesis?

zork824Jul 21, 20141 votes

Ehi! Sorry if I bother, but you are a QA analyst, mind checking this topic please? Thank you in advance :) http://boards.na.leagueoflegends.com/en/c/champions-skins/Nx65KFm6-riot-karthus-bug

Mike4RealJul 22, 20143 votes

it took me a few seconds to fix it i think the current plans would have the fix out to north america early this week, though i don't know exactly when as that's handled by other teams.

This right here is a problem. I've noticed hotfixes are happening less and less often. Granted this may be because the issues that used to be hotfixed in the past are no longer happening, or you guys are deciding an issue is not impactful enough to warrant a hotfix. However, I believe the systems you guys are implementing over the past year and a half have slowed down your ability to make changes to the game on the fly. If you are able to fix something in seconds, you should be able to hotfix it that night.

You being slowed down by other teams and individuals you do not have information from is a bad sign. You are the one who fixed it, you should immediately have the information of when the fix will occur. Either that or make it happen yourself (I realize this may not be how your company works anymore). I think that since patches are planned so far ahead of time at Riot, when something deviates from the plan it takes more time to be acted upon then in the past.

I agree that this kind of thing shouldn't happen in the first place, but it almost certainly will again sometime. When that time comes I am concerned that the coders will once again be limited by what the whole deployment team and various other people want to do. Make sure to keep the lines of communication open with them. You must not sacrifice game quality for any other influences.

Ironclad DragonJul 21, 20146 votes

One line of code? You might be discrediting how difficult programming can be.

gamezzsJul 21, 20143 votes

One line of code? You might be discrediting how difficult programming can be.

I know how complicated programming is, but in theory items should be as simple as a bunch of properties linked together and applied to the champion when in use. I don't doubt that this bug is an emergent one, how only riot knows, but it SHOULD be as simple as adding or removing a trait from the item.(key word being should).

Ironclad DragonJul 21, 20142 votes

Touche.

Sir ArmaMalumJul 21, 20145 votes

Knowing the issues that have cropped up in weird places in League's spaghetti code, it's probably a lot more than one line of code. Were you here during Hecarim Patch? Now THAT was a fun bundle of bugs. I still have no idea how anything in Hec patch managed to make Gragas' model never update (causing him to suddenly appear somewhere to everyone else) or cause fps drops in even the best machines. And the global laughs, oh god the global laughs.

Needless to say, although their code base is much better than back then, knowing how much worse it could be I'm fine with waiting an extra day or two.

PtarlorrJul 21, 20141 votes

Well, that sounds like fun times. So Gragas esentially had Teemo's passive?

Sir ArmaMalumJul 21, 20143 votes

Oh no much more entertaining than that. At a random time, something'll break and the Gragas player will sem to freeze to everyone else, although he's perfectly fine himself. Then whenever he cast an ability, auto attacked, used a spell, item active or anything additional that affects the server-side his still-frozen model would suddenly blink to where the action happened.

I had a hilarious time scaring a friend of mine in a co-op vs ai match because my model had frozen when I had died, so random dead gragas body would just appear suddenly next to my buddy. It was like a fat-man version of Slender, League version.

PtarlorrJul 21, 20141 votes

Sounds hilarious, wish I was there.

Sire HippingtonJul 21, 20142 votes

U asume they already know WHY Sorcs give double pen with homeguards. It usually takes alot more time to find out why something doesn't work right than it takes to fix it afterwards. And as Sir ArmaMalum said, by the history of lolbugs the code is probably (unecessary-)complex and it will be more than just 1 line of code(one would asume it's just adjusting one value for homeguard-sorcs, but it's obviously not as simple for them)