is crit an on hit effect
i was just wondering if something like guinsoos would be viable on an adc other than kog maw, just because it means you crit twice, the reason i am asking is because of gangplanks q which is on hit and it can crit
i was just wondering if something like guinsoos would be viable on an adc other than kog maw, just because it means you crit twice, the reason i am asking is because of gangplanks q which is on hit and it can crit
No. Crit is just taking the physical damage normally applied from an AA and multiplying it by 2 (2.5 if have IE), ignoring champions with crit damage reductions (e.g. Yasuo) or runes and items with magic damage than can crit (e.g. shiv)
GP's Q is a special ability that is basically behaves like an autoattack. Same with Ezreals's Q. Its why they are able to apply damage/effects that are normally procced by autoattacks (shiv procs, iceborn gauntlets slow field, etc).
Unless otherwise stated I'm pretty sure they're on attack.