Skip to content

Shop refund resets gealth to level it was at when shop page was opened

FactualAction··12 votes·7,521 views

I've noticed that occasionally when I refund an item (like a potion or a ward) I take a ton of damage. You can see the same bug happen to Trick2g at 1:30 in the video I linked where he refunds a potion and takes 300ish damage. After some testing in custom games, I think I have a way to consistently reproduce the bug:

1 Take in a lot of damage in a custom game, down to something like 10% of max. 2 While casting the recall, open the shop and try to buy an item continuously while recalling. Any item works. 3 Once you are back at the pool, let yourself regen. 4 Stay in the pool and return/refund the item you just bought while watching your health. 5 See tons of damage from refunding the item.

It's not usually a game breaking bug, but it forces me to sit in the fountain an extra 5ish seconds so I can regen health that I already regenerated, and those seconds can make a big difference when trying to get back to lane.

19 Comments

RiotRiot Afic8 votes

Thanks for this report!

Although this isn't ideal, it is actually intended.

Gonna go into waaaay too much detail, but if you are curious read on! The first reason it was implemented this way is to prevent players from buying/undoing item buys to heal faster. The way it works, is when you buy an item with health, the game will increase your max health, and then on the next tick heals you for an amount equal to the amount of health you gained. The obvious solution is then on item undo, also reduce your current health by the amount of health the item had. The problem with this solution is with the old item Spirit of the Ancient Golem (which gave you more health based on a % of your current max health). This made it so the amount of health an item gave wasn't always the same, and ultimately the current implementation is a result of that. We could probably address this (there are likely other abuse cases I am missing) but there is also a possibility we introduce another item with a similar effect, in which case this bug will return.

TL;DR the game will remember your health when you buy an item, and revert to that value after an undo.

Again, this isn't ideal, but I hope it at least gives some insight into why it is this way.

Hope this helps!

Eotw4 votes

Why doesn't it just maintain the % of max HP? For instance, regardless of whether the health increases or decreases, if you had 10% of your max HP before, you'd have 10% afterwards.

kayakninja1 votes

Now that Spirit of the Ancient Golem is out of the game, do you think we're going to see this change?

GundayMonday1 votes

I guess that makes sense. Thanks for the explanation!

TheKingDodo2 votes

Thanks for this report!

Although this isn't ideal, it is actually intended.

Gonna go into waaaay too much detail, but if you are curious read on! The first reason it was implemented this way is to prevent players from buying/undoing item buys to heal faster. The way it works, is when you buy an item with health, the game will increase your max health, and then on the next tick heals you for an amount equal to the amount of health you gained. The obvious solution is then on item undo, also reduce your current health by the amount of health the item had. The problem with this solution is with the old item Spirit of the Ancient Golem (which gave you more health based on a % of your current max health). This made it so the amount of health an item gave wasn't always the same, and ultimately the current implementation is a result of that. We could probably address this (there are likely other abuse cases I am missing) but there is also a possibility we introduce another item with a similar effect, in which case this bug will return.

TL;DR the game will remember your health when you buy an item, and revert to that value after an undo.

Again, this isn't ideal, but I hope it at least gives some insight into why it is this way.

Hope this helps!

Why not just have it apply to health/mana/regen/homeguards items only? I lose health when I undo buy a long sword. and that's just outrageous Taric truly truly...

ShadowGlaive2131 votes

I was in a bot game as Lux earlier and I refunded my grail (not a health item) for spell pen boots and I lost health though =X

Coffee Ray Gun4 votes

I think it resets you to the state you were in when you bought the item, I wonder if buying an item while a debuff is on you (e.g. Morde's ult) and then undoing would reset the debuff.

Also, there's a small typo in the thread title, see if you can find it :3.

FactualAction1 votes

Yeah I noticed it the moment I posted it. Sadly I can't edit the title to fix it.

Looks like you're right, it resets to state of purchase. Still a pretty bad bug imo.

FactualAction1 votes

Looks like Coffee Ray Gun is right, it's health state at item purchase, not shop page open. Still a bug! :)

Coffee Ray Gun2 votes

I don't think it's a bug so much as it's an oversight, still needs to be fixed no matter what it's called xD.

Be Kind Rewind1 votes

Why do you think it's a bug? I was always pretty sure it was intentional.
What if you buy an HP5 item, and then resell it a few moments later? You keep all the hp regen it just gave you temporarily?
What about the same for mana regen?
What about weird situations like buying a tank item, getting hit in the fountain, then re-selling it? You get to have tanked temporarily, without paying for the item?
Heck, what about flat max HP / max Mana boosting items? How would you handle % regen with those? Imagine buying something like chalice and tear. Mana font increases your mana, and the tear's max mana increase makes Mana font increase it even more rapidly. So then you resell them both and get to have all of that mana restore, temporarily, for free?

These might sound silly and insignificant, but I'm pretty sure the whole point is to avoid these situations. **It makes sure you didn't get any unfair advantage by temporarily owning an item before re-selling it - by just reverting you to your pre-item-buy state. **

I think the reason it seems like a glitch is because it's shown as if you actually just took damage, though, instead of just reverting back to a different health amount.

GundayMonday2 votes

Here's a video of it happening to me. Bought a red pot. Didn't use it, refunded it. Down ~1k hp: https://www.youtube.com/watch?v=uY_46Pp-ejs

Eotw2 votes

Most of what you described, such as the mana font, is so insignificant that if you want to micromanage yourself to that extent, you deserve the 1/4 second you might save. You'll probably sacrifice it in other ways before you even leave the fountain.

As for the rest, if you get hit in the fountain, you should not be able to undo.

Be Kind Rewind1 votes

I'm not saying it's practical or even necessary. But as described by the Red post in this thread, it seems that is essentially the reason for the feature.

Also, to be fair, I think it is necessary. It has a very minimal impact, sure. But so does, for example, move-attacking jungle monsters as a pure melee in the jungle. The slight delay it gives the monsters makes you survive with slightly more health, and puts you slightly closer to the next camp. So the pros have all done it. In cases of emergency, you don't suppose pros would buy a massive health regen item, to get out of base ASAP, then dump them quickly once they're about full?

For context; there was a game in this last LCS season, I believe, where one team was literally one auto-attack from taking the nexus. But the last surviving enemy got out of the fountain just in time to save the nexus. And then they came back and won.

That's a fringe case, but what if, for example, that "last-hit on the nexus" comes down to, "I grabbed a spirit visage, then re-sold it briefly and barely won the fight by 50 hp, saving the nexus."

That seems unlikely. But if they can prevent that from happening, why not? So that we don't feel like we're taking damage when we refund stuff? Do you want them to let the issue remain just because it doesn't feel like it will probably become significant?

Eotw2 votes

Let's put a number to that feeling. My entire point revolves around the fact that, unlike move-attacking in the jungle, you wouldn't get any benefit by spending the time to do it.

The best item to increase health regen is Warmog's by far at 3% HP per 5 seconds. You recover 2.1% of your max HP every 0.25 seconds while in spawn, which equates to 12 seconds to fully heal. In this time, you could potentially heal 7% of your health from Warmog's, saving half a second in the absolute best case scenario.

But wait! If you sell the Warmog's, you'll have nearly 3k gold sitting in your inventory. No pro would leave fountain with that kind of cash. That means that you have to buy the item you want after selling Warmog's. Realistically, even the pros wouldn't be able to gain more than 1/4 of a second doing this. And this is time they focused on micromanaging spawn instead of scoping out the map!

If you still want to argue that it's significant, the obvious solution is to disable health and mana regen while in spawn outside of the spawn's regen itself.

Be Kind Rewind1 votes

Let's put a number to that feeling. My entire point revolves around the fact that, unlike move-attacking in the jungle, you wouldn't get any benefit by spending the time to do it.

The best item to increase health regen is Warmog's by far at 3% HP per 5 seconds. You recover 2.1% of your max HP every 0.25 seconds while in spawn, which equates to 12 seconds to fully heal. In this time, you could potentially heal 7% of your health from Warmog's, saving half a second in the absolute best case scenario.

But wait! If you sell the Warmog's, you'll have nearly 3k gold sitting in your inventory. No pro would leave fountain with that kind of cash. That means that you have to buy the item you want after selling Warmog's. Realistically, even the pros wouldn't be able to gain more than 1/4 of a second doing this. And this is time they focused on micromanaging spawn instead of scoping out the map!

If you still want to argue that it's significant, the obvious solution is to disable health and mana regen while in spawn outside of the spawn's regen itself.

No, my argument isn't that it's significant. My argument is that, "it's an insignificant issue therefore Riot shouldn't fix it" is a bad argument. It's a small issue that could have more severe implications in the future depending on itemization changes, that Riot prevents from being an issue with the current system. The only problem is feeling weird about having it 'damage you' back to your prior health, or the slight moment longer it'll take you to get out of fountain due to the refund. But if you're sitting around, buying an item, waiting a bit, then refunding it, urgency is clearly not an issue.

Eotw2 votes

When the fix is worse than the issue, "Riot shouldn't fix it" is very reasonable.

If Riot is going to fix it, they should fix it properly. Like I said, health and mana regen can simply be disabled while in spawn.

GundayMonday1 votes

Happened to me last night. Messed up a teamfight when I had WAY less health than expected. https://www.youtube.com/watch?v=uY_46Pp-ejs

More from Report a Bug