I feel as if Diana is a bit underwhelming for all she is worth.
Disclaimer: I am not the highest of ranks (Gold 3), nor am I the highest of mastery on Diana (106k / Lvl 7).
I have been playing Diana for a while, now and I feel as if she is underwhelming for what she offers. She falls in such a weird spot between a fighter and an assassin, when all she has ever seen viability as is an assassin. For as far as I remember, I don't think it has ever been viable for Diana to be built on the tankier side. A overwhelming majority of the people build her as an AP assassin. Most of her abilities have mixed messages, for example, Diana's passive.
INNATE: Casting an ability grants Diana 30% − 90% (based on Moonfall Moonfall's Rank) Attack speed icon bonus attack speed for her next 3 basic attacks on-hit.
Every third basic attack on-hit within 3.5 seconds cleaves nearby enemies for 20 − 250 (based on level) (+ 80% AP) Ability power bonus magic damage and restores Mana icon (15% AP) mana.
This seems like the attack speed would be better on a fighter who weaves autos in between trades, where as most of the time I feel like Diana either one shots the person and makes no use of this, or uses the extra attack speed on the first auto to execute someone. Another thing that has always felt off about Diana is the fact that her passive fades away. It just makes Diana, an already impulsive assassin, feel even more impulsive. Diana's champion already feels like you have to constantly be going in to scale, and making her passive fade so quickly.
Diana's kit is also blighted by the fact that she gets out-scaled and out-mechanic-ed by newer fighters like Irelia, and newer assassins like Akali. A lot of the newer fighters have either tons of defensive stats build-in, or newer assassins have multiple escape or get out if need be. That is I think Diana's biggest problem. She has absolutely no escape! If she goes in, it is a complete suicide mission. Champions like Zed, Talon and Akali (especially this one), have lot's of viability since they have the ability to kill someone and get out where as Diana doesn't have the ability to do that, and I think that is one of her biggest weaknesses.
TL;DR: Diana's is a sucide-y, mage-assassin-fighter that fits none of those roles, who gets stomped early game, and even if you get fed isn't rewarding unless you do well above average, she deserves some kind of buff/change to bring her more up to speed with the meta.