Auto Attack Modifiers and On Hits

RecentlyAs has been the case since forever, abilities that is, applies, or in any way interact with on hit effects, lifesteal and crits are clarity nightmares. Some crits, some hit towers, some do crazy weird stuff to the game. Coupled with Riposte, Aegis Protection, Blinding effects and Dodge, it is pure hell

I understand that they are the way they are for balance reasons, but I remember how insanely confusing it was when I first started playing. Even now, I don't really think most people know every single property of every ability so at the very least the tooltip should be really clear as to what the abilities do

As it is, it seems to me that the general rule is that physical damage spells that procs on hit effects will lifesteal with the bonus damage and crit your AD amount without the bonus damage, but sometimes it won't crit at all. Riposte and Aegis Protection blocks most. Whether it damages towers is random

Most are confusing enough, but I personally think there are two worst offenders: Gangplank: Parrrley crits with bonus damage and is considered melee(wut????) Poppy: Devastating Blow converts all damage including crit and spell blade into magic damage and only spell vamps(dafuq?)

There are a few that are plain misleading: Nidalee: Takedown only lifesteals despite being magic damage(huh?) Rek'sai: Queen's Wrath bonus damage interacts literally with nothing, not with spell vamp, lifesteal, towers, dodge, block, nothing Yorick: Omen of War bonus damage won't lifesteal but the 0.2AD will crit Draven: Spinning Axes is actually an on hit effect but changes your AD stats Warwick: Infinite Duress converts all damage to magic damage including spell blade but will not crit